Lines of Code
[root]/Classes/Validation/Validator
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 456 (100.0%) | 4036 (100.0%) | 8.8 |
| robert | 135 (29.6%) | 2230 (55.3%) | 16.5 |
| k-fish | 296 (64.9%) | 791 (19.6%) | 2.6 |
| networkteam_hlubek | 8 (1.8%) | 471 (11.7%) | 58.8 |
| andi | 14 (3.1%) | 348 (8.6%) | 24.8 |
| kgusak | 2 (0.4%) | 147 (3.6%) | 73.5 |
| sebastian | 1 (0.2%) | 49 (1.2%) | 49.0 |
Removed everything in trunk after move to git.
0 lines of code changed in 54 files:
[-TASK] FLOW3: Removed @version keyword from files, resolves #8835.
0 lines of code changed in 24 files:
[~TASK] ExtJS: Added doc comments to a few methods. Added basic parameter check for transaction arguments.
[+BUGFIX] ExtJS (ExtDirect): Fixed a bug which resulted in a broken communication between client and server via ExtDirect if a shared action method had optional arguments. Resolves #9279
[~TASK] FLOW3 (MVC): Cleaned up the code and documentation of the JsonView
[+FEATURE] FLOW3 (Persistence): The base repository now only sets the repository's object type if it has not been defined before. By that it is possible to define a custom object type in the property declaration of a concrete repository.
[+FEATURE] FLOW3 (Property): The property mapper now supports creation and recreation of objects specified by a UUID in an identity array even if they are just part of the overall source object / array to be mapped.
[+BUGFIX] FLOW3 (Validation): Fixed a few failing tests of composite validators, caused by incorrect mock building.
2 lines of code changed in 1 file:
[+FEATURE] FLOW3 (I18n): Locale-aware validators added. Relates to #9246.
147 lines of code changed in 2 files:
[+BUGFIX] FLOW3 (Validation): Some validators did not reset stale errors on isValid() calls, fixes #8558.
6 lines of code changed in 5 files:
[+FEATURE] FLOW3 (Validation): Implemented a "label" validator which matches characters you usually would want to allow in labels. Resolves #7474
1 lines of code changed in 1 file:
[+BUGFIX] FLOW3 (Resource): Added a safeguard into the ResourceObjectConverter which detects if a file upload has previously been converted to an object. Without this check it could happen that FLOW3 tries to move the uploaded file multiple times, which doesn't work of course.
[+BUGFIX] FLOW3 (Validation): Added a type safeguard to the StringLengthValidator
8 lines of code changed in 1 file:
[+FEATURE] FLOW3 (Validation): The @validate annotations in action methods now support an object accessor syntax ($argument.subobject.subsubobject) for declaring additional validation rules referring to a property of a nested object. Resolves #6993
[~TASK] FLOW3 (Validation): Brushed up and unified the messages of most validators.
[~TASK] FLOW3 (Error): The var_dump method now also filters PHPUnit Invocation Mokers.
39 lines of code changed in 14 files:
[+BUGFIX] FLOW3 (Object): The object serializer now serializes only the properties of the target class if the given object is proxied.
[+BUGIFX] FLOW3 (Property): The property mapper now handles optional constructor arguments of target objects correctly.
[+BUGFIX] FLOW3 (Validation): The Generic Object Validator now also accepts NULL as a valid value.
[+BUGFIX] FLOW3 (Validation): The Validator Resolver now correctly builds validator conjunctions even recursively for properties of the given data type.
5 lines of code changed in 2 files:
[~TASK] FLOW3 (Validation): Some documentation cleanup to DisjunctionValidator, resolves #6727.
5 lines of code changed in 1 file:
[+BUGFIX] FLOW3 (Validation): EmailAddressValidator accepts valid IP addresses now, fixes #6806.
1 lines of code changed in 1 file:
[+FEATURE] FLOW3 (Core): The flow3 hell script now uses the PHP binary specified in the PHP environment variable, resolves #6681.
[~TASK] FLOW3: Some SVN property maintenance.
1 lines of code changed in 1 file:
[+FEATURE] FLOW3 (Object): Implemented a static object container which is automatically built. It's essentially a hardcoded version of the autowired and configured object dependencies - just a lot faster. Many tests are still missing, but the version in this commit should be mostly functional. Addresses #3740 and resolves #2123.
[!!!][~API] FLOW3 (Object): Heavily refactored the Object Manager and its tests. The most important change is the removal of the Object Factory whose create() method is now located in the Object Manager. Furthermore, the getObject() method has been renamed to get() and a few minor important API functions within the Object Manager have been modified. This commit also contains a script which allows for semi automatically migrating existing code to the new API (see ./flow3 migrate objectmanagerusage). Resolves #6562
[~TASK] FLOW3 (Configuration): The Configuration Manager and its YAML source now doesn't depend on the YAML package anymore but refers to a YAML parser class within the FLOW3 package. Resolves #6564.
7 lines of code changed in 2 files:
[+FEATURE] FLOW3 (Cache): Implemented a PHP Cache Frontend which allows for effective caching of PHP code which is included with require_once() instead of runtime parsing with eval(). This significantly improves speed when used in combination with an opcode cache such as APC. Currently only the FileBackend supports PHP code caching. Resolves #6137
[+FEATURE] FLOW3 (AOP): The AOP Framework now uses the new PHP cache frontend for storing AOP proxy classes. Speeds up the initial startup of FLOW3 enormously. Relates to #6137
[~TASK] FLOW3: Removed all dependencies from the PHP6 package because the unicode support we were using didn't really make sense in the respective situations.
[+BUGFIX] FLOW3 (Utility): Fixed a bug in Files::emptyDirectoryRecursively() which wrongly recognized certain files as directories due to incorrect usage of the directory iterator.
1 lines of code changed in 1 file:
[+BUGFIX] FLOW3 (Reflection): ObjectAccess::getProperty() now throws an exception when a property does not exist, fixes #6005.
[~TASK] FLOW3 (Reflection): GenericObjectValidator now checks properties even if they are not accessible normally.
9 lines of code changed in 1 file:
[~TASK] FLOW3 (Validation): The EmailAddressValidator now rejects addresses with more than one @ sign as well as non-word characters at the end. Fixes #6089.
2 lines of code changed in 1 file:
[~TASK] Global: Commit of those files whose case of the filename changed. Relates to #5658
1 lines of code changed in 1 file:
[~TASK] FLOW3 (Documentation): Updated the Coding Guidelines: removed inconsistent exceptions from the general class naming rules. Also added the rule that names of aspect classes must end with "Aspect". Relates to #5658
[~TASK] Global: Renamed many classes and interfaces in order to be consistent with FLOW3's naming rules. A migration script to update third-party applications will follow soon. Resolves #5658
67 lines of code changed in 5 files:
[~TASK] FLOW3: Added @api annotations on class level and adjusted CGL to explain class-level @api handling.
24 lines of code changed in 22 files:
[!!!][~API] FLOW3 (Validation): The RangeValidator now expects the arguments "minimum" and "maximum" instead of "startRange" and "endRange". The CountValidator also uses "minimum" and "maxmimum", previously it was "min" and "max"
[!!!][~API] FLOW3 (MVC): The recently introduced class "FlashMessages" was renamed to "FlashMessageContainer" and the property name within the AbstractController was changed to "flashMessageContainer" accordingly. Check your controller code for use of $this->flashMessages!
[!!!][~API] Fluid (ViewHelper): Renamed the "RenderFlashMessages" view helper to "FlashMessages". Replace "<f:renderFlashMessages" by "<f:flashMessages" in your templates if you already used this new feature.
10 lines of code changed in 2 files:
[+FEATURE] FLOW3 (Validation): Added CountValidator, resolves #3956.
2 lines of code changed in 1 file:
[-API] FLOW3 (MVC): Removed enableValidation() and disableValidation() on the Controller Argument. They are not needed anymore.
[!!!][+BUGFIX] FLOW3 (MVC): Now, in case people do not specify an @param annotation, they will get an exception instead of Text being used.
[+BUGFIX] FLOW3 (MVC): Cleaned up validator registration in ActionController. Now, @dontvalidate annotations only disable the model-based validators.
[+BUGFIX] FLOW3 (Validation): Cleaned up ValidatorResolver. Now, Validators which check the data type from the @param annotation are also added to the validator chain.
[!!!][+BUGFIX] FLOW3 (Validation): @param string is now validated as string, and not anymore as Text. This fixes numerous bug reports in Fluid.
49 lines of code changed in 1 file:
[~TASK] FLOW3: Fixed method parameter documentation found by new reflection service checks.
[+FEATURE] FLOW3 (Persistence): added removeAll() to base repository, resolves #3852.
1 lines of code changed in 1 file:
[~API] FLOW3 (Property): The map() method of the Mapper now accepts a class name as $target and tries to do the right thing (fetch, fetch/clone or create the right object).
[+FEATURE] FLOW3 (Property): When mapping to objects, UUIDs and identity arrays are now mapped to objects recursively.
[+BUGFIX] FLOW3 (Property): Mapping to plain arrays is now possible, fixes #4443.
[~TASK] FLOW3 (MVC): Streamlined setValue() in Controller\Argument.
[~TASK] FLOW3 (Validation): UUIDValidator - moved regular expression match pattern for UUID to class constant.
[~TASK] FLOW3 (Property): Fixed inheritance chain for some exceptions.
[~TASK] FLOW3 (Cache): Changed string character access from {} to [].
7 lines of code changed in 1 file:
[~BUGFIX] FLOW3 (Validation): The ValidatorResolver test case failed - but only if the Blog package was installed. This was due to some Blog model being used by a data provider which in reality should have been a sample, not existing class. Fixed that.
[~TASK] FLOW3 (Validation): The TextValidator was too restrictive because it did not allow line breaks and other common characters - now it does. However, it's not really secure yet. Relates to #3977
[+BUGFIX] Fluid (Core): Added some safe guard and aception to the Abstract Node which would exit with a fatal error in some cases.
1 lines of code changed in 1 file:
[+TASK] FLOW3: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Fluid: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Kickstart: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] PHP6: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] PHPUnit: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Testing: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Welcome: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] YAML: Removed file level docblocks and @package/@subpackage annotations.
0 lines of code changed in 21 files:
[TASK] FLOW3: moved from @internal to @api, resolves #3883
36 lines of code changed in 20 files:
[FIX] FLOW3 (MVC): Moved mapping of UUIDs to objects into ArgumentsValidator, fixes #3726
[TASK] FLOW3 (MVC): Removed Argument\setNewFilterChain() and related tests, as Filter\Chain does no longer exist
[TASK] FLOW3: Some cleanup to documentation, added type hint, removed use statement
1 lines of code changed in 1 file:
Added svn:keywords where missing...
6 lines of code changed in 3 files:
FLOW3:
* fixed wrong object name in GenericObjectValidator (never use leading \ in strings!)
1 lines of code changed in 1 file:
FLOW3:
* some whitespace paranoia^Wcleanup
* removed a use statement
* (re-)introduced some inject methods - in FLOW3 itself we do not use @inject
4 lines of code changed in 1 file:
Object validation: Introduced PropertyError for nested errors and changed property mapper and mapping results. Resolves #3401
21 lines of code changed in 1 file:
Renamed AbstractJunctionValidator to AbstractCompositeValidator
121 lines of code changed in 3 files:
* Added DisjunctionValidator for a disjunction of validators
* Introduced a new AbstractJunctionValidator as a base class for the conjunction and disjunction validators
189 lines of code changed in 3 files:
Refactored ChainValidator to ConjunctionValidator and changed behaviour to validate all nested validators
140 lines of code changed in 1 file:
FLOW3:
* fixed error message created by AlphanumericValidator
1 lines of code changed in 1 file:
This commit is all about validation. Although the new features basically work, a few smaller features and tweak are missing before the whole concept works as intended. Documentation will follow (hopefully soon).
* FLOW3: (Validation) Implemented annotation based validation for models. That means you now can define validation rules by adding @validate annotations to class properties and these rules will be enforced when arguments of this type are passed as controller arguments. Resolves #3093 but some fine tuning and small additional features are missing.
* FLOW3: (Validation) Note that #3130 is not solved yet in this commit.
* FLOW3: (MVC) Implemented a MVC Controller Arguments Validator which is able to validate a whole Arguments object. This is used during the mapAndValidate process in the controller. Addresses #3093.
* FLOW3: (Property) The property mapper now accepts arrays as source and / or target.
* FLOW3: (Property) mapAndValidate() will now truly validate the result of the mapping. If the result does not validate, the target remains unchanged.
* FLOW3: (Validation) Removed the Filter Chain for now - it will surely come back but didn't work like it was currently implemented.
* FLOW3: (Validation) Improved the AbstractValidator and added a new AbstractObjectValidator
* FLOW3: (Validation) Adapted all validators to the new Validator interface and AbstractValidator
* FLOW3: (Validation) Implemented a new Generic Object validator which can validate properties of any object
* FLOW3: (Validation) Simplified the chaining of validators and during that process removed the ObjectValidatorChainValidator
* FLOW3: Added and adapted many tests
232 lines of code changed in 17 files:
* FLOW3: Raised required PHP version to 5.3.0RC1
* FLOW3: (Error) The \F3\FLOW3\Error\Error class now supports __toString()
* FLOW3: (MVC) Finished implementation of validation rules in the action methods. Now these rules are actually enforced. Now really resolves #3092.
* FLOW3: (MVC) The ActionController now checks if it can process the request ? didn't do that before. Fixes #3121.
* FLOW3: (Property) The property mapper's mapAndValidate() method now actually validates the source.
* FLOW3: (Reflection) The Reflection Service now detects class file changes again. (Problem was that the settings were not injected anymore because autowiring was turned off for the Reflection Service in the Objects.yaml) Fixes #3152.
* FLOW3: (Validation) Removed the Validation\Errors class - now a simple array is used instead.
* FLOW3: (Validation) Removed the $errors argument from FilterInterface::filter(). More changes to this interface will follow.
* FLOW3: (Validation) Validation options must be set with the new setOptions() method instead of passing them to the isValid() method.
* FLOW3: (Validation) The errors array is not passed to the isValid() method of a validator anymore - instead it can be retrieved by a new getErrors() method which is defined in the ValidatorInterface.
* FLOW3: (Validation) Validators may now be singleton or prototype. Marked all those validators as prototype which require options and let others be singletons.
* FLOW3: (Validation) Removed the public resolveValidatorClassName() method from the ValidatorResolver class.
* FLOW3: (Validation) !!! changed the option names of the StringLength validator: now they are "minimum" and "maximum"
* FLOW3: (Validation) Changed the ObjectValidatorInterface: canValidateType() is now canValidate() and asks for an objects instead of a class name.
* FLOW3: (Validation) The first argument of the Validator Resolver's createMethodValidator() has changed: Now either the short name or a fully qualified object name of a _validator_ is expected (instead of the data type)! Maybe also addresses #3130.
* FLOW3: (Documentation) Added a few lines of documentation and an example for the validation rules feature. More to come.
* Fluid: (Core) Fixed a test which was referring to the \F3\FLOW3\Validation\Errors class.
242 lines of code changed in 18 files:
FLOW3:
* TextValidator now uses filter_var() to check value, refs #2851
2 lines of code changed in 1 file:
FLOW3(Validation):
* Implemented the StringLengthValidator. Resolves #2832.
16 lines of code changed in 1 file:
(27 more)