Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 222 (100.0%) | 4933 (100.0%) | 22.2 |
| robert | 88 (39.6%) | 2440 (49.5%) | 27.7 |
| k-fish | 98 (44.1%) | 1472 (29.8%) | 15.0 |
| sebastian | 15 (6.8%) | 337 (6.8%) | 22.4 |
| andi | 5 (2.3%) | 320 (6.5%) | 64.0 |
| networkteam_hlubek | 10 (4.5%) | 254 (5.1%) | 25.4 |
| bwaidelich | 6 (2.7%) | 110 (2.2%) | 18.3 |
Removed everything in trunk after move to git.
0 lines of code changed in 16 files:
[+BUGFIX] FLOW3 (MVC): Fixed leftover use of flashMessages variable in ActionController, fixes #4850.
23 lines of code changed in 1 file:
[!!!][~API] FLOW3 (Validation): The RangeValidator now expects the arguments "minimum" and "maximum" instead of "startRange" and "endRange". The CountValidator also uses "minimum" and "maxmimum", previously it was "min" and "max"
[!!!][~API] FLOW3 (MVC): The recently introduced class "FlashMessages" was renamed to "FlashMessageContainer" and the property name within the AbstractController was changed to "flashMessageContainer" accordingly. Check your controller code for use of $this->flashMessages!
[!!!][~API] Fluid (ViewHelper): Renamed the "RenderFlashMessages" view helper to "FlashMessages". Replace "<f:renderFlashMessages" by "<f:flashMessages" in your templates if you already used this new feature.
94 lines of code changed in 3 files:
[!!!][+BUGFIX] FLOW3 (MVC): The RESTController no longer defines the $id argument for methods, this fixes #4013. You must declare the $id argument properly in your controller actions from now on!
0 lines of code changed in 1 file:
[+FEATURE] FLOW3 (MVC): Removed EmptyView and made NotFoundView display helpful message instead, resolves #4405.
37 lines of code changed in 1 file:
[~TASK] FLOW3 (MVC): adjusted tests to removed default data type for Controller\Argument
4 lines of code changed in 2 files:
[-API] FLOW3 (MVC): Removed enableValidation() and disableValidation() on the Controller Argument. They are not needed anymore.
[!!!][+BUGFIX] FLOW3 (MVC): Now, in case people do not specify an @param annotation, they will get an exception instead of Text being used.
[+BUGFIX] FLOW3 (MVC): Cleaned up validator registration in ActionController. Now, @dontvalidate annotations only disable the model-based validators.
[+BUGFIX] FLOW3 (Validation): Cleaned up ValidatorResolver. Now, Validators which check the data type from the @param annotation are also added to the validator chain.
[!!!][+BUGFIX] FLOW3 (Validation): @param string is now validated as string, and not anymore as Text. This fixes numerous bug reports in Fluid.
115 lines of code changed in 3 files:
[!!!][~FEATURE] FLOW3 (MVC): Improved the way flash messages are handled. Now there is a separate "FlashMessages" object which encapsulates handling the flash messages. This removes $this->pushFlashMessage and $this->popFlashMessages inside the Controller and {flashMessages} inside Fluid Template. PLEASE UPGRADE by replacing "$this->pushFlashMessage(" with "$this->flashMessages->add(" inside your Controllers, and use <f:renderFlashMessages /> instead of the custom for loop inside your templates. Note: You can set a custom CSS class for outputting flash messages by using <f:renderFlashMessages class="..." /> inside your templates. Resolves #4638.
92 lines of code changed in 2 files:
[+FEATURE] FLOW3 (MVC): Now, non-domain-objects can be mapped inside an argument as well. Additionally, improved the exceptions in these cases. Resolves #4631
33 lines of code changed in 1 file:
14 lines of code changed in 3 files:
[~API] FLOW3 (Property): The map() method of the Mapper now accepts a class name as $target and tries to do the right thing (fetch, fetch/clone or create the right object).
[+FEATURE] FLOW3 (Property): When mapping to objects, UUIDs and identity arrays are now mapped to objects recursively.
[+BUGFIX] FLOW3 (Property): Mapping to plain arrays is now possible, fixes #4443.
[~TASK] FLOW3 (MVC): Streamlined setValue() in Controller\Argument.
[~TASK] FLOW3 (Validation): UUIDValidator - moved regular expression match pattern for UUID to class constant.
[~TASK] FLOW3 (Property): Fixed inheritance chain for some exceptions.
[~TASK] FLOW3 (Cache): Changed string character access from {} to [].
26 lines of code changed in 1 file:
[+FEATURE] FLOW3 (MVC): It is now possible to disable validation temporarily for single controller arguments. This is necessary in situations where a knowingly incomplete / invalid argument needs to be passed to an action, for example an edit action. Validation can be disabled either by calling the disableValidation() method on the argument object or by adding a @dontvalidate $argumentName annotation to an action method. Resolves #4166
[+TASK] FLOW3 (Documentation): Documented the new @dontvalidate annotation.
[+FEATURE] FLOW3 (Package): The package manager's command line controller now returns a friendly error message on trying to activate or deactivate an already active or inactive package. Earlier it just threw an unpolished exception.
[+FEATURE] FLOW3 (Persistence): Implemented an update() method for the base repository which allows for conveniently updating existing objects. update() only expects one argument which must be a clone of the object to replace, already containing the modifications. The object passed to update() must internally contain the same uuid like the object to be updated (ie. replaced). In fact this new update() method is basically a more convenient way to call replace(). Resolves #4167
[+BUGFIX] FLOW3 (MVC): A @validate annotation placed in an action method's comment replaced existing rules instead of adding them to a common conjunction validator. By this it was possible to override any validation rule with a simple @validate $foo Raw annotation. Fixes #4168
108 lines of code changed in 3 files:
[+TASK] FLOW3 (MVC): Added the previously committed method assignMultiple() to the ViewInterface
2 lines of code changed in 1 file:
[-TASK] FLOW3: Removed (some more) file level docblocks.
[-TASK] Testing: Removed (some more) file level docblocks.
0 lines of code changed in 2 files:
[~TASK] FLOW3: moved class schema handling from Persistence to Reflection, resolves #3934.
4 lines of code changed in 1 file:
[+TASK] FLOW3: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Fluid: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Kickstart: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] PHP6: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] PHPUnit: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Testing: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Welcome: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] YAML: Removed file level docblocks and @package/@subpackage annotations.
0 lines of code changed in 6 files:
[TASK] FLOW3 (Tests): Fixed some issues found while trying PHPUnit 3.4
[TASK] Fluid (Tests): Fixed some issues found while trying PHPUnit 3.4
[TASK] TYPO3CR (Tests): Fixed some issues found while trying PHPUnit 3.4
1 lines of code changed in 1 file:
[FIX] FLOW3 (MVC): Different fix for #3795, now arguments are cleared only on forward(), fixes #3795
31 lines of code changed in 2 files:
[FIX] FLOW3 (MVC): Fixed test for error action that used Arguments object for forward, refs #3790
3 lines of code changed in 1 file:
* [FIX] FLOW3 (MVC): Arguments are reset on each call to processRequest, fixes #3795
* [FIX] FLOW3 (MVC): Fixed wrong type hints in AbstractController and added the param for redirect arguments
* [+FEAT] FLOW3 (MVC): Implemented a generic error action for the ActionController with automatic forwarding to the referrer action and with storage of errors in the request. Resolves #3790
104 lines of code changed in 2 files:
[TAKS] FLOW3 (MVC): Moved mapping of UUIDs to objects from ArgumentsValidator to Argument, refs #3726
17 lines of code changed in 2 files:
[FIX] FLOW3 (MVC): Moved mapping of UUIDs to objects into ArgumentsValidator, fixes #3726
[TASK] FLOW3 (MVC): Removed Argument\setNewFilterChain() and related tests, as Filter\Chain does no longer exist
[TASK] FLOW3: Some cleanup to documentation, added type hint, removed use statement
42 lines of code changed in 3 files:
* [TASK] FLOW3 (Monitor): Renamed F3\FLOW3\Monitor\ChangeDetectionStrategy\ModificationTime to F3\FLOW3\Monitor\ChangeDetectionStrategy\ModificationTimeStrategy
* [TASK] FLOW3 (Core): Move the F3\FLOW3\FLOW3 class into its own sub package "Core". The class is now called "Bootstrap".
* [+FEAT] FLOW3 (Core): Implemented a basic locking mechanism which locks the whole site while code caches are cleared. It's basically working but currently not customizable. Try it out by changing some code somewhere and then run two requests (in dev context) almost simultaneously. The Lock Manager is invoked on file changes through the Signal Slot mechanism. Resolves #3581
* [TASK] FLOW3: Simplified the index.php bootstrap a little and adjusted paths for the new Core sub package.
* [FIX] FLOW3 (SignalSlot): Added a check within the Signal Slot dispatcher which now throws a meaningful exception if a given slot class does not exist. Resolves #3730
* [TASK] FLOW3: Updated FLOW3's Package.xml file.
* [TASK] FLOW3: Commented out the SetEnv declaration in the .htaccess file. FLOW3 runs in Production context by default anyway and if the environment is set in the .htaccess file by default, any environment set in a virtual host wouldn't have any effect.
1 lines of code changed in 1 file:
[+FEAT] FLOW3 (MVC): Arguments validator behaves like the generic object validator and creates an ArgumentError with information about the erroneous argument
50 lines of code changed in 1 file:
* FLOW3: (MVC) Fixed test for last commit. sorry.
0 lines of code changed in 1 file:
* FLOW3: (MVC) !!! Moved the code from ActionController::initializeView() to resolveView() and introduced a new (empty) initializeView($view) method which can be used to initialize arbitrary views or let developers do some cusomt initialization without having to resolve the view themselves. Resolves #1501
9 lines of code changed in 2 files:
* FLOW3: (MVC) Implemented automatic conversion of UUIDs into objects retrieved from a repository in the Abstract Controller. This is the counterpart to the object to UUID conversion in the Fluid view helpers. Resolves #1789
* FLOW3: (MVC) !!! Renamed the recently introduced methods queueFlashMessage() and getFlashMessages() to pushFlashMessage() and popFlashMessages() respectively.
33 lines of code changed in 1 file:
FLOW3:
* Removed FLOW3\Utility\GenericCollection from repository, it's currently not needed. Resolves #3400
* Moved method setArgumentsFromRawRequestData() from Router to RequestBuilder. Resolves #3368
* Renamed URIHelper to URIBuilder. Removed Classes HelperInterface, AbstractHelper and InvalidViewHelper Exception. Adapted AbstractView & ViewInterface. Resolves #3303
* Added section parameter to URIFor() method of the URIBuilder
* Refactored Base controllers - controllerContext is no instance variable anymore and will be created when passed to view in initializeView(). Resolves #3404
* ControllerContext is of scope prototype now. Added setter/getter for URIBuilder. Some cosmetic changes.
* Added getRequestPath() to Request.
* ControllerKeys (@controller, @action, @package, @subpackage and @format) can now be set by request arguments. Resolves #2853
57 lines of code changed in 3 files:
FLOW3:
* added flash message handling to AbstractController and ActionController, resolves #2819
Blog:
* removed preliminary flash message handling, replaced by solution for #2819
59 lines of code changed in 2 files:
Fluid:
* Fluid\TemplateView and it's interface now have a hasTemplate() method, resolves #3385
FLOW3:
* Fluid is now the default templating engine, resolves #3382
34 lines of code changed in 1 file:
Fixes #3302: implementing a Controller Context except for adding the URIhelper
79 lines of code changed in 2 files:
Refactored ChainValidator to ConjunctionValidator and changed behaviour to validate all nested validators
18 lines of code changed in 4 files:
* FLOW3: (MVC) Introduced a RequestInterface and a ResponseInterface and made sure those are used everywhere where the Request class was used before.
* FLOW3: (Documentation) Continued writing documentation for the MVC framework.
13 lines of code changed in 1 file:
This commit is all about validation. Although the new features basically work, a few smaller features and tweak are missing before the whole concept works as intended. Documentation will follow (hopefully soon).
* FLOW3: (Validation) Implemented annotation based validation for models. That means you now can define validation rules by adding @validate annotations to class properties and these rules will be enforced when arguments of this type are passed as controller arguments. Resolves #3093 but some fine tuning and small additional features are missing.
* FLOW3: (Validation) Note that #3130 is not solved yet in this commit.
* FLOW3: (MVC) Implemented a MVC Controller Arguments Validator which is able to validate a whole Arguments object. This is used during the mapAndValidate process in the controller. Addresses #3093.
* FLOW3: (Property) The property mapper now accepts arrays as source and / or target.
* FLOW3: (Property) mapAndValidate() will now truly validate the result of the mapping. If the result does not validate, the target remains unchanged.
* FLOW3: (Validation) Removed the Filter Chain for now - it will surely come back but didn't work like it was currently implemented.
* FLOW3: (Validation) Improved the AbstractValidator and added a new AbstractObjectValidator
* FLOW3: (Validation) Adapted all validators to the new Validator interface and AbstractValidator
* FLOW3: (Validation) Implemented a new Generic Object validator which can validate properties of any object
* FLOW3: (Validation) Simplified the chaining of validators and during that process removed the ObjectValidatorChainValidator
* FLOW3: Added and adapted many tests
218 lines of code changed in 4 files:
FLOW3:
* changed $viewObjectNamePattern in ActionController to expect views classes in a namespace reflecting the controller name
* renamed DefaultController to StandardController to follow suit
* renamed DefaultView to StandardView to follow suit
* updated documentation
FLOW3 Distribution:
* updated Routes.yaml
Fluid:
* renamed DefaultController to StandardController
Testing:
* renamed DefaultController to StandardController
TYPO3CR:
* renamed DefaultController to StandardController in Admin subpackage
* moved view classes to new location
3 lines of code changed in 1 file:
* FLOW3: Raised required PHP version to 5.3.0RC1
* FLOW3: (Error) The \F3\FLOW3\Error\Error class now supports __toString()
* FLOW3: (MVC) Finished implementation of validation rules in the action methods. Now these rules are actually enforced. Now really resolves #3092.
* FLOW3: (MVC) The ActionController now checks if it can process the request ? didn't do that before. Fixes #3121.
* FLOW3: (Property) The property mapper's mapAndValidate() method now actually validates the source.
* FLOW3: (Reflection) The Reflection Service now detects class file changes again. (Problem was that the settings were not injected anymore because autowiring was turned off for the Reflection Service in the Objects.yaml) Fixes #3152.
* FLOW3: (Validation) Removed the Validation\Errors class - now a simple array is used instead.
* FLOW3: (Validation) Removed the $errors argument from FilterInterface::filter(). More changes to this interface will follow.
* FLOW3: (Validation) Validation options must be set with the new setOptions() method instead of passing them to the isValid() method.
* FLOW3: (Validation) The errors array is not passed to the isValid() method of a validator anymore - instead it can be retrieved by a new getErrors() method which is defined in the ValidatorInterface.
* FLOW3: (Validation) Validators may now be singleton or prototype. Marked all those validators as prototype which require options and let others be singletons.
* FLOW3: (Validation) Removed the public resolveValidatorClassName() method from the ValidatorResolver class.
* FLOW3: (Validation) !!! changed the option names of the StringLength validator: now they are "minimum" and "maximum"
* FLOW3: (Validation) Changed the ObjectValidatorInterface: canValidateType() is now canValidate() and asks for an objects instead of a class name.
* FLOW3: (Validation) The first argument of the Validator Resolver's createMethodValidator() has changed: Now either the short name or a fully qualified object name of a _validator_ is expected (instead of the data type)! Maybe also addresses #3130.
* FLOW3: (Documentation) Added a few lines of documentation and an example for the validation rules feature. More to come.
* Fluid: (Core) Fixed a test which was referring to the \F3\FLOW3\Validation\Errors class.
47 lines of code changed in 2 files:
* FLOW3: (MVC) Implemented the automatic validation rule registration based on @validate annotations in action methods. Note that validators are registered now but validation still does not happen (yet). Resolves #3092
* FLOW3: (Validation) Modified the API of the ValidatorResolver
57 lines of code changed in 2 files:
* FLOW3: (MVC) A method called "initializeFooAction" will now be called before an action "foo" at a time arguments still can be registered. Resolves #3091
* FLOW3: (MVC) !!! Removed the initializeArguments() method from the ActionController. Use initializeXYAction() or initializeAction() instead!
26 lines of code changed in 1 file:
* Fluid: (ViewHelpers) Implemented a mechanism which automatically renders a hidden identity field into a form if the form's object attribute is set.
* TYPO3CR: (FLOW3) Fixed the matchUUID() constraint.
5 lines of code changed in 1 file:
FLOW3:
* Added default arguments implementation in MVC
55 lines of code changed in 3 files:
(53 more)