Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 127 (100.0%) | 4505 (100.0%) | 35.4 |
| bwaidelich | 33 (26.0%) | 2935 (65.1%) | 88.9 |
| k-fish | 59 (46.5%) | 854 (19.0%) | 14.4 |
| robert | 35 (27.6%) | 716 (15.9%) | 20.4 |
Removed everything in trunk after move to git.
0 lines of code changed in 16 files:
[+FEATURE] FLOW3 (MVC): If mod_rewrite is not available generated links will include index.php, resolves #87.
[~TASK] FLOW3 (MVC): Fixed filename of UriBuilderTest.
[~TASK] Welcome: made sure the link to MyPackage works if mod_rewrite is disabled.
268 lines of code changed in 1 file:
[+BUGFIX] FLOW3 (MVC): resolve() in Router now handles (nested) domain objects correctly, fixes #4441.
8 lines of code changed in 1 file:
213 lines of code changed in 1 file:
[~TASK] FLOW3 (MVC): replaced objectFactory & objectManager by mock objects in RouteTest, added some tests. This resolves #2556
268 lines of code changed in 1 file:
[+TASK] FLOW3: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Fluid: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Kickstart: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] PHP6: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] PHPUnit: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Testing: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Welcome: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] YAML: Removed file level docblocks and @package/@subpackage annotations.
0 lines of code changed in 5 files:
[TASK] FLOW3 (Tests): Removed a bunch of tests checking the object handling rather than the test target
[TASK] TYPO3CR (Tests): Removed a bunch of tests checking the object handling rather than the test target
0 lines of code changed in 3 files:
FLOW3:
* !!! BREAKING CHANGE !!! F3\FLOW3\Configuration\Manager is now able to load sub routes from packages and merge them with main routes. Resolves #2126 (This needs further testing and some cleanup!)
* !!! BREAKING CHANGE !!! Routes are not processed in reverse order anymore. Resolves #3441.
* Query string won't be lowercased anymore by the routing framework. Relates to #2237.
* Added some missing type hints to F3\FLOW3\Configuration\Manager
* Improved exception messages in F3\FLOW3\MVC\Web\Routing\Route
FLOW3 Distribution:
* !!! BREAKING CHANGE !!! adapted global routes to the changes mentioned above and added subroutes to FLOW3/TYPO3CR packages.
3 lines of code changed in 1 file:
FLOW3:
* Removed FLOW3\Utility\GenericCollection from repository, it's currently not needed. Resolves #3400
* Moved method setArgumentsFromRawRequestData() from Router to RequestBuilder. Resolves #3368
* Renamed URIHelper to URIBuilder. Removed Classes HelperInterface, AbstractHelper and InvalidViewHelper Exception. Adapted AbstractView & ViewInterface. Resolves #3303
* Added section parameter to URIFor() method of the URIBuilder
* Refactored Base controllers - controllerContext is no instance variable anymore and will be created when passed to view in initializeView(). Resolves #3404
* ControllerContext is of scope prototype now. Added setter/getter for URIBuilder. Some cosmetic changes.
* Added getRequestPath() to Request.
* ControllerKeys (@controller, @action, @package, @subpackage and @format) can now be set by request arguments. Resolves #2853
247 lines of code changed in 2 files:
Bug fixes during the TYPO3 Bugday on T3DD09
* FLOW3: (MVC) Added typehint to AbstractView / ViewInterface setControllerContext()
* FLOW3: (MVC) Removed the resolving of an object's identity from the Dynamic Route Part handler. This needs to be implemented in a specialized, dedicated route part handler. Refs #1789
* FLOW3: (MVC) A Route now converts route values which are objects into their uuid.
* FLOW3: (MVC) Fixed a typo in the Router which cause a fatal error (sometimes). setRoutePartConfigurations()
* FLOW3: (MVC) Adapted the tests for the DynamicRoutePart handler
20 lines of code changed in 2 files:
Routing:
* Added Rout Part Options to be able to add arbitrary configurations to rout parts. This resolves #2825.
* Spare matchValues are added to the resolved URI as query parameters
* Moved common properties & methods to RoutePartInterface
* some Cosmetic changes
19 lines of code changed in 1 file:
* FLOW3: (Persistence) Renamed the methods getUUID($object) to getUUIDByObject($object) and removed one of them from the Persistence Manager (now ask the Persistence Backend instead).
* FLOW3: (Persistence) Implemented a replace() method for the base Repository. Resolves #2979
4 lines of code changed in 1 file:
This is a commit of work in progress. If you're already using FLOW3 (semi-) productively, you better skip this version because the MVC framework currently lacks validation and might lead to some other unexpected behavior. OTOH the code seems to be quite stable, so nothing to really worry about. More code related to the MVC framework and especially validation will follow soon, I just had to get rid of all these changes ...
* FLOW3: (Persistence) Made sure that the object name "...\Persistence\ManagerInterface" is used everywhere instead of "...\Persistence\Manager".
* FLOW3: (Error) Annotated the "Error" and "Warning" class as prototype and renamed *ErrorMessage() and *ErrorCode() to *Message() and *Code().
* FLOW3: (MVC) Fixed and re-enabled tests of the Abstract Controller
* FLOW3: (MVC) !!! Started rewriting the argument mapping mechanism. It should work but be aware that NO VALIDATION and NO FILTERING is active at the moment!
* FLOW3: (MVC) The automatic argument registration in the Action Controller now detects optional arguments and registers them as such.
* FLOW3: (MVC) Cleaned up the Argument(s) classes and implemented an early version of identity support in setValue()
* FLOW3: (MVC) Added initial implementation of identity support for the resolve() method of a DynamicRoutePart. I'll give more information on this topic as soon as it's completely implemented.
* FLOW3: (MVC) Removed the emit* method in the router and replaced it by a call to the System Logger: Now the log contains an entry stating which route has been chosen.
* FLOW3: (Persistence) In the ClassSchema renamed the (is)RepositoryManaged property and methods to (is)AggregateRoot.
* FLOW3: (Persistence) Added safeguard to the Persistence\Manager::getClassSchema() method
* FLOW3: (Property / MVC) For now, completely removed the concept of Property Converters!
* FLOW3: (Property) Started reimplementing the Property Mapper. Most of the old functionality has been removed but much of it will return soon.
* FLOW3: (Reflection) Changed the order of access method detection in the ObjectAccess class. Any other order causes proplems in the MVC mechanism. If a property could not be accessed, now NULL is returned (instead of throwing an exception)
* FLOW3: (Validation) Moved the AbstractValidator and Validation interfaces to the Validator sub package
* Fluid: (ViewHelpers) Added support for an "arguments" attribute in the FormViewHelper which allows for specifying arguments for the action URI.
66 lines of code changed in 2 files:
FLOW3:
* removed controllerObjectNamePattern and viewObjectNamePattern from some places, refs #2444
* added caching to routing, based on work by Bastian and Sebastian, fixes #1791
* the Router resolve()s in lowercase and matches case-insensitive now, refs #2237
TYPO3CR:
* adjustments to Routes.yaml suggestion
2 lines of code changed in 2 files:
FLOW3:
* improved strategy pattern implementation in DynamicRoutePart to simplify creation of custom RoutePartHandlers.
* parsed URI pattern is not represented as uriPatternSegmentCollection anymore but as simple array of Route Parts making URI matching more flexible and easier to comprehend.
* added Interfaces RoutePartInterface and DynamicRoutePartInterface
* improved error handling for invalid URI patterns. Replaced F3\FLOW3\MVC\Exception\SuccessiveDynamicRouteParts by F3\FLOW3\MVC\Exception\InvalidUriPattern.
* lots of smaller tweaks
* BREAKING CHANGES:
* moved all Routes to global Configuration/Routes.yaml. Addresses #2126.
* dynamic Route Parts are no longer enclosed by square brackets but by curly brackets. Resolves #2342.
* removed support for query strings in URI pattern for now. It increased complexity and wasn't really needed yet.
* added support for optional route parts. Just put the respective parts in brackets in your URI pattern. NOTE: Dynamic Route Parts are no longer optional by default (even if a default value is set). Resolves #1790.
459 lines of code changed in 3 files:
* FLOW3: (MVC) (mostly) implemented automatic registration of action arguments: Now you don't need to register arguments manually with $this->arguments->addNewArgument(...); but just write an action method with arguments and document them properly in the method's DocComment. Note that only basic support is implemented yet (stringm, integer and object arguments) and that other validators (such as "required") are not yet configured automatically. Addresses #2506.
* FLOW3: (MVC) !!! Removed the initializeController() method from the AbstractController. Didn't find any meaningful use case at the moment (use initializeObject() instead!)
* FLOW3: (MVC) Wrote proper tests for the ActionController (old ones didn't use mock objects)
* Fluid: (View) Fixed resolveTemplatePathAndFilename() in the TemplateView: If no sub package was defined, the path contained a double slash "...//..""
* Testing: Added more convience functions to the Accessible Proxy: with $proxy->_get() and $proxy->_set() even protected properties can be retrieved and set
1 lines of code changed in 1 file:
!!! Globally renamed all class files to the new shorter version. Resolves #2524
FLOW3: (Resource) Adapted the class loader and other related parts of FLOW3 to the new class filename convention
FLOW3: Moved the FLOW3 bootstrap into the F3\FLOW3 namepace
320 lines of code changed in 6 files:
FLOW3:
* fixed license name in @license annotation, fixes #2454
6 lines of code changed in 6 files:
FLOW3:
* changed license to LGPL v3 or later
84 lines of code changed in 6 files:
FLOW3:
* some MVC tests refactored
6 lines of code changed in 4 files:
!!! 5.3.0alpha3 namespaces refactoring:
* changed namespace delimiter from :: to \
* all class references in namespaced code prepended by \
PHPUnit:
* adapted mock object handling to the new namespaces syntax
FLOW3:
* PropertyReflection now uses setAccessible() instead of array cast to access protected properties
PHPCR:
* added a missing interface already used for type hints
136 lines of code changed in 6 files:
* FLOW3: (Component) Renamed "component" to "object" - everywhere. That means we now have an Object Manager instead of a Component Manager, an Object Factory etc. Resolves #2119
Globally adjusted all code for the above change.
61 lines of code changed in 6 files:
* FLOW3: (MVC) Added F3::FLOW3::Utility::GenericCollection - a "type-safe" collection which implements the SPL interfaces ::Countable, ::Iterator and ::ArrayAccess. You can create an instance of a type-safe by passing the complete class name of allowed objects to the constructor or by inheriting from this class and calling parent::__construct.
* FLOW3: (MVC) Big refactoring in routing classes: $uriPatternSegments and $uriPatternQueryParameters are no arrays any longer but instances of F3::FLOW3::Utility::GenericCollection. Route Parts get a reference to that collection injected in order to be able to walk through the current segment and retrieve information about subsequent Route Parts. This is required for upcoming feature "optional Route Parts" and makes setSplitString() and setLastRoutePartInSegment() obsolete. Restructuring of route test case to retain clarity. Behaviour shouldn't have changed at all.
500 lines of code changed in 5 files:
* Fixed FLOW3's yaml configuration: exceptional errors were defined as plain strings instead of constants resulting in even (catchable) fatal errors being ignored
* Fixed several tests which still used the object configuration instead of arrays
4 lines of code changed in 1 file:
* FLOW3: (Component) Renamed the method Component::Factory->getComponent() to Component::Factory->create(). Resolves #1846
* FLOW3: (Component) Component::Factory->create() will now throw an exception on trying to create a component of scope != prototype
* FLOW3: (Component) The Component::Manager->getComponent() method can still be used as a last resort to retrieve components of any scope. However dependency injection for singletons and the component factory for prototype should always be the first choice!
Refactored all packages of the TYPO3 distribution to match the above changes.
Note: The test "F3::TYPO3CR::NodeTest::setPropertySetsValue" currently fails on my machine with the following message:
Error in setPropertySetsValue with data set #34 Detail
TYPO3CR/Classes/F3_TYPO3CR_Node.php:577
Unable to convert value of type string to Name: Namespace prefix is invalid
45 lines of code changed in 4 files:
FLOW3:
* added array_reduce() variant to Utility::Arrays that accepts any type for $initial
* removed some whitespace in RouteTest
9 lines of code changed in 1 file:
* FLOW3: (MVC) Changed handling of Query parameters in URIs. They are ignored now, unless explicitly configured in URI pattern. This fixes #1635. Note: if you want to access a query parameter, you still have to add it to your route.
* FLOW3: (MVC) Some smaller tweaks and fixes in Route class.
158 lines of code changed in 1 file:
* FLOW3: (MVC) Renamed "URL" to "URI" in unit tests too.
78 lines of code changed in 3 files:
* FLOW3: (MVC) Refactored and added tests for the Route Class.
* FLOW3: (MVC) Renamed all occurrences of urlPattern to uriPattern in routing classes (we decided to stick with "URI" rather than "URL" from now on).
* TYPO3CR: Updated Routes.php to set uriPattern instead of urlPattern.
* TYPO3: Updated Routes.php to set uriPattern instead of urlPattern. Removed obsolete dynamic Route Part from fallback uriPattern.
202 lines of code changed in 3 files:
!!! Major change, will break existing code.
Part 3 - Packages
FLOW3, most other packages:
* added namespaces to the code of FLOW3 and all packages in the current TYPO3v5 distribution.
PHPUnit:
* some changes to make PHPUnit (more) namespace-compatible.
Some notes:
* Documentation updates will follow
* you might need to change your class names when adapting namespaces to avoid using "Class", "Empty", "Default", ...
* expect FLOW3CGL and/or PHPCodeSniffer to be broken (I'll have a look)
* some parts might still be broken, especially in edge-cases where the global namespace needs to explicitly used
57 lines of code changed in 4 files:
* FLOW3: (MVC) Implemented first version of a "reverse routing" mechanism which is the first step for creating proper URLs in FLOW3. Now you can generate links like this:
$router->resolve(array('@package' => 'myPackage', '@controller' => 'myController'));
But beware, naming will probably change and we're working on a link-helper to be able to create correct URLs more conveniently.
186 lines of code changed in 3 files:
FLOW3:
* fixed a bunch of CGL violations
* some TODO comments converted into @todo annotations
65 lines of code changed in 3 files:
* FLOW3: (MVC) Added check to F3_FLOW3_MVC_Web_Routing_StaticRoutePart: if its the last route part in the current URL segment, name of the route part must be exactly the same as the remaining string in the segment. This is a temporary fix and will be refactored soon. This fixes #1278.
3 lines of code changed in 1 file:
* FLOW3: Marked the previously, mistakenly committed test as skipped. Relates to #1278
1 lines of code changed in 1 file:
* FLOW3: (Configuration) Made sure that the global settings and the routing configuration is always loaded in the same order (and does not depend on the file system's ordering abilities). Asserted that the FLOW3 routing and settings are always loaded first. Relates to #1278
* FLOW3: (MVC) A few cosmetic changes.
21 lines of code changed in 2 files:
* FLOW3: (MVC) Add route part handler support. A route part handler is basically nothing else than a specialized F3_FLOW3_MVC_Web_Routing_DynamicRoutePart and can be used to resolve one or multiple URL segments. Resolves #1251.
Note: There is no implementation of a route part handler yet.
59 lines of code changed in 1 file:
* FLOW3: (MVC) Added new property "lastRoutePartInSegment" to F3_FLOW3_MVC_Web_Routing_StaticRoutePart to indicate whether a route part is the last in the current url segment. This fixes #1264.
Routing classes are quite messy and complex at the moment. Refactoring and cleanup is needed!
42 lines of code changed in 2 files:
* FLOW3: (MVC) Added "splitString"-property to F3_FLOW3_MVC_Web_Routing_DynamicRoutePart to add support for multiple route parts within one URL pattern segment. This resolves #1250.
* FLOW3: (MVC) Removed F3_FLOW3_MVC_Web_Routing_SubRoutePart as a "subroute part" is technically just some special form of a "dynamic route part".
* FLOW3: (MVC) Added another route to exemplify the usage of "splitStrings". Refactored routing classes.
118 lines of code changed in 2 files:
* FLOW3: (Configuration) Configuration containers are now locked recursively. Fixes #1064.
* FLOW3: (MVC) Since recently it was allowed to set keys like "FLOW3_MVC" as package key in the Request object in order to route into sub packages. That was kind of dirty. Now there's a new option setControllerComponentNamePattern() which can be reached from the routes configuration. This doesn't work in CLI mode though (routing into sub packages that is)
* FLOW3: (Package) The package object did not check if the specified package key is valid - now it does.
* TYPO3: Further experiments with the routing and the different controllers.
10 lines of code changed in 1 file:
* FLOW3: (MVC) Implemented tests for the F3_FLOW3_MVC_Request class.
* FLOW3: (Utility + MVC) Added support for PUT, DELETE, HEAD and OPTIONS request methods.
4 lines of code changed in 1 file:
(4 more)