Lines of Code
[root]/Tests/Validation/Validator
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 279 (100.0%) | 4607 (100.0%) | 16.5 |
| robert | 83 (29.7%) | 2030 (44.1%) | 24.4 |
| k-fish | 180 (64.5%) | 1997 (43.3%) | 11.0 |
| andi | 12 (4.3%) | 262 (5.7%) | 21.8 |
| networkteam_hlubek | 3 (1.1%) | 247 (5.4%) | 82.3 |
| sebastian | 1 (0.4%) | 71 (1.5%) | 71.0 |
Removed everything in trunk after move to git.
0 lines of code changed in 46 files:
[!!!][~API] FLOW3 (Validation): The RangeValidator now expects the arguments "minimum" and "maximum" instead of "startRange" and "endRange". The CountValidator also uses "minimum" and "maxmimum", previously it was "min" and "max"
[!!!][~API] FLOW3 (MVC): The recently introduced class "FlashMessages" was renamed to "FlashMessageContainer" and the property name within the AbstractController was changed to "flashMessageContainer" accordingly. Check your controller code for use of $this->flashMessages!
[!!!][~API] Fluid (ViewHelper): Renamed the "RenderFlashMessages" view helper to "FlashMessages". Replace "<f:renderFlashMessages" by "<f:flashMessages" in your templates if you already used this new feature.
8 lines of code changed in 2 files:
[+FEATURE] FLOW3 (Validation): Added CountValidator, resolves #3956.
2 lines of code changed in 1 file:
[-API] FLOW3 (MVC): Removed enableValidation() and disableValidation() on the Controller Argument. They are not needed anymore.
[!!!][+BUGFIX] FLOW3 (MVC): Now, in case people do not specify an @param annotation, they will get an exception instead of Text being used.
[+BUGFIX] FLOW3 (MVC): Cleaned up validator registration in ActionController. Now, @dontvalidate annotations only disable the model-based validators.
[+BUGFIX] FLOW3 (Validation): Cleaned up ValidatorResolver. Now, Validators which check the data type from the @param annotation are also added to the validator chain.
[!!!][+BUGFIX] FLOW3 (Validation): @param string is now validated as string, and not anymore as Text. This fixes numerous bug reports in Fluid.
71 lines of code changed in 1 file:
[~BUGFIX] FLOW3 (Validation): The ValidatorResolver test case failed - but only if the Blog package was installed. This was due to some Blog model being used by a data provider which in reality should have been a sample, not existing class. Fixed that.
[~TASK] FLOW3 (Validation): The TextValidator was too restrictive because it did not allow line breaks and other common characters - now it does. However, it's not really secure yet. Relates to #3977
[+BUGFIX] Fluid (Core): Added some safe guard and aception to the Abstract Node which would exit with a fatal error in some cases.
21 lines of code changed in 1 file:
[+TASK] FLOW3: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Fluid: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Kickstart: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] PHP6: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] PHPUnit: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Testing: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] Welcome: Removed file level docblocks and @package/@subpackage annotations.
[+TASK] YAML: Removed file level docblocks and @package/@subpackage annotations.
0 lines of code changed in 16 files:
Added svn:keywords where missing...
4 lines of code changed in 2 files:
FLOW3:
* fixed test broken since r2374
* tweaked another test
9 lines of code changed in 1 file:
Object validation: Introduced PropertyError for nested errors and changed property mapper and mapping results. Resolves #3401
77 lines of code changed in 1 file:
* Added testcase for the DisjunctionValidator
8 lines of code changed in 1 file:
Refactored ChainValidator to ConjunctionValidator and changed behaviour to validate all nested validators
162 lines of code changed in 1 file:
FLOW3:
* fixed testcase for AlphanumericValidator. Argh.
3 lines of code changed in 1 file:
This commit is all about validation. Although the new features basically work, a few smaller features and tweak are missing before the whole concept works as intended. Documentation will follow (hopefully soon).
* FLOW3: (Validation) Implemented annotation based validation for models. That means you now can define validation rules by adding @validate annotations to class properties and these rules will be enforced when arguments of this type are passed as controller arguments. Resolves #3093 but some fine tuning and small additional features are missing.
* FLOW3: (Validation) Note that #3130 is not solved yet in this commit.
* FLOW3: (MVC) Implemented a MVC Controller Arguments Validator which is able to validate a whole Arguments object. This is used during the mapAndValidate process in the controller. Addresses #3093.
* FLOW3: (Property) The property mapper now accepts arrays as source and / or target.
* FLOW3: (Property) mapAndValidate() will now truly validate the result of the mapping. If the result does not validate, the target remains unchanged.
* FLOW3: (Validation) Removed the Filter Chain for now - it will surely come back but didn't work like it was currently implemented.
* FLOW3: (Validation) Improved the AbstractValidator and added a new AbstractObjectValidator
* FLOW3: (Validation) Adapted all validators to the new Validator interface and AbstractValidator
* FLOW3: (Validation) Implemented a new Generic Object validator which can validate properties of any object
* FLOW3: (Validation) Simplified the chaining of validators and during that process removed the ObjectValidatorChainValidator
* FLOW3: Added and adapted many tests
193 lines of code changed in 14 files:
* FLOW3: Raised required PHP version to 5.3.0RC1
* FLOW3: (Error) The \F3\FLOW3\Error\Error class now supports __toString()
* FLOW3: (MVC) Finished implementation of validation rules in the action methods. Now these rules are actually enforced. Now really resolves #3092.
* FLOW3: (MVC) The ActionController now checks if it can process the request ? didn't do that before. Fixes #3121.
* FLOW3: (Property) The property mapper's mapAndValidate() method now actually validates the source.
* FLOW3: (Reflection) The Reflection Service now detects class file changes again. (Problem was that the settings were not injected anymore because autowiring was turned off for the Reflection Service in the Objects.yaml) Fixes #3152.
* FLOW3: (Validation) Removed the Validation\Errors class - now a simple array is used instead.
* FLOW3: (Validation) Removed the $errors argument from FilterInterface::filter(). More changes to this interface will follow.
* FLOW3: (Validation) Validation options must be set with the new setOptions() method instead of passing them to the isValid() method.
* FLOW3: (Validation) The errors array is not passed to the isValid() method of a validator anymore - instead it can be retrieved by a new getErrors() method which is defined in the ValidatorInterface.
* FLOW3: (Validation) Validators may now be singleton or prototype. Marked all those validators as prototype which require options and let others be singletons.
* FLOW3: (Validation) Removed the public resolveValidatorClassName() method from the ValidatorResolver class.
* FLOW3: (Validation) !!! changed the option names of the StringLength validator: now they are "minimum" and "maximum"
* FLOW3: (Validation) Changed the ObjectValidatorInterface: canValidateType() is now canValidate() and asks for an objects instead of a class name.
* FLOW3: (Validation) The first argument of the Validator Resolver's createMethodValidator() has changed: Now either the short name or a fully qualified object name of a _validator_ is expected (instead of the data type)! Maybe also addresses #3130.
* FLOW3: (Documentation) Added a few lines of documentation and an example for the validation rules feature. More to come.
* Fluid: (Core) Fixed a test which was referring to the \F3\FLOW3\Validation\Errors class.
113 lines of code changed in 15 files:
FLOW3:
* TextValidator now uses filter_var() to check value, refs #2851
15 lines of code changed in 1 file:
FLOW3(Validation):
* Implemented the StringLengthValidator. Resolves #2832.
42 lines of code changed in 1 file:
FLOW3:
* added DateTime validator
* made some validator unit tests actually test what they test
82 lines of code changed in 11 files:
* FLOW3: (MVC) For now removed the ArgumentsValidator. It will surely reappear in a different form, but currently doesn't fit anymore.
* FLOW3: (Validation) Refactored the ValidatorInterface and the ObjectValidatorInterface and adapated all of their implementations including tests. The interfaces are cleaner and more intuitive now.
* TestPackage: Removed a few classes which were not used anymore. We're really close to getting rid of the whole TestPackage once and for all!
1438 lines of code changed in 13 files:
This is a commit of work in progress. If you're already using FLOW3 (semi-) productively, you better skip this version because the MVC framework currently lacks validation and might lead to some other unexpected behavior. OTOH the code seems to be quite stable, so nothing to really worry about. More code related to the MVC framework and especially validation will follow soon, I just had to get rid of all these changes ...
* FLOW3: (Persistence) Made sure that the object name "...\Persistence\ManagerInterface" is used everywhere instead of "...\Persistence\Manager".
* FLOW3: (Error) Annotated the "Error" and "Warning" class as prototype and renamed *ErrorMessage() and *ErrorCode() to *Message() and *Code().
* FLOW3: (MVC) Fixed and re-enabled tests of the Abstract Controller
* FLOW3: (MVC) !!! Started rewriting the argument mapping mechanism. It should work but be aware that NO VALIDATION and NO FILTERING is active at the moment!
* FLOW3: (MVC) The automatic argument registration in the Action Controller now detects optional arguments and registers them as such.
* FLOW3: (MVC) Cleaned up the Argument(s) classes and implemented an early version of identity support in setValue()
* FLOW3: (MVC) Added initial implementation of identity support for the resolve() method of a DynamicRoutePart. I'll give more information on this topic as soon as it's completely implemented.
* FLOW3: (MVC) Removed the emit* method in the router and replaced it by a call to the System Logger: Now the log contains an entry stating which route has been chosen.
* FLOW3: (Persistence) In the ClassSchema renamed the (is)RepositoryManaged property and methods to (is)AggregateRoot.
* FLOW3: (Persistence) Added safeguard to the Persistence\Manager::getClassSchema() method
* FLOW3: (Property / MVC) For now, completely removed the concept of Property Converters!
* FLOW3: (Property) Started reimplementing the Property Mapper. Most of the old functionality has been removed but much of it will return soon.
* FLOW3: (Reflection) Changed the order of access method detection in the ObjectAccess class. Any other order causes proplems in the MVC mechanism. If a property could not be accessed, now NULL is returned (instead of throwing an exception)
* FLOW3: (Validation) Moved the AbstractValidator and Validation interfaces to the Validator sub package
* Fluid: (ViewHelpers) Added support for an "arguments" attribute in the FormViewHelper which allows for specifying arguments for the action URI.
83 lines of code changed in 13 files:
!!! Globally renamed all class files to the new shorter version. Resolves #2524
FLOW3: (Resource) Adapted the class loader and other related parts of FLOW3 to the new class filename convention
FLOW3: Moved the FLOW3 bootstrap into the F3\FLOW3 namepace
83 lines of code changed in 13 files:
FLOW3:
* fixed license name in @license annotation, fixes #2454
13 lines of code changed in 13 files:
FLOW3, Lucene, PHP6, PHPCR, Smarty, Testing, TYPO3, TYPO3CR, TypoScript:
* fixed broken @version $Id$ annotations that got hosed during new namespace refactoring. Sorry!
4 lines of code changed in 2 files:
FLOW3:
* changed license to LGPL v3 or later
182 lines of code changed in 13 files:
FLOW3:
* refactored a bunch of unit tests so they no longer need a real FLOW3 to run, refs #2123
137 lines of code changed in 12 files:
!!! 5.3.0alpha3 namespaces refactoring:
* changed namespace delimiter from :: to \
* all class references in namespaced code prepended by \
PHPUnit:
* adapted mock object handling to the new namespaces syntax
FLOW3:
* PropertyReflection now uses setAccessible() instead of array cast to access protected properties
PHPCR:
* added a missing interface already used for type hints
162 lines of code changed in 13 files:
* FLOW3: (Component) Renamed "component" to "object" - everywhere. That means we now have an Object Manager instead of a Component Manager, an Object Factory etc. Resolves #2119
Globally adjusted all code for the above change.
35 lines of code changed in 10 files:
FLOW3:
* cleaned up some more validator tests
* using filter_var() for integer validator now (other validators cannot be switched, as they don't do what we want)
63 lines of code changed in 2 files:
FLOW3:
* streamlined the test for the email address validator
33 lines of code changed in 1 file:
FLOW3:
* the email address validator now accepts IP addresses as host parts
* the regex is formatted more readable
61 lines of code changed in 1 file:
FLOW3:
* fixed/enhanced documentation in validators
* changed/fixed float and integer validation from strings
* added some is_string() checks to speed up validation for invalid properties
79 lines of code changed in 2 files:
FLOW3 (Validation): Fixed the integer validator. Now it handles strings correctly
FLOW3 (Security): Implemented the missing decision and ACL classes. No we can authenticate a user and authorize methods over AOP!
24 lines of code changed in 1 file:
Set svn:keywords property to Id on all PHP files.
18 lines of code changed in 9 files:
FLOW3: Enhanced the email address validator. I love RFC822. :)
52 lines of code changed in 1 file:
FLOW3: Cleaned up the validators a little to reduce code duplication
66 lines of code changed in 8 files:
* FLOW3 (Error): Fixed the constructor of the Error class
* FLOW3 (Validation): Validators now fill the passed Errors object with Error objects, if validation fails
* FLOW3 (MVC): Fixed the arguments validator to handle the validation errors correctly
* FLOW3 (Property): Changed the property mapper. Now it can handle nested errors (Validation::Errors objects as well as Validation::Error objects) added to the errors object by object validators
196 lines of code changed in 10 files:
!!! Major change, will break existing code.
Part 3 - Packages
FLOW3, most other packages:
* added namespaces to the code of FLOW3 and all packages in the current TYPO3v5 distribution.
PHPUnit:
* some changes to make PHPUnit (more) namespace-compatible.
Some notes:
* Documentation updates will follow
* you might need to change your class names when adapting namespaces to avoid using "Class", "Empty", "Default", ...
* expect FLOW3CGL and/or PHPCodeSniffer to be broken (I'll have a look)
* some parts might still be broken, especially in edge-cases where the global namespace needs to explicitly used
148 lines of code changed in 13 files:
* FLOW3: (Validation) Added a "raw" validator which accepts just everything. Resolves #1092
49 lines of code changed in 1 file:
* FLOW3: (Validation) Implemented new validator for UUIDs.
* TYPO3: (Domain) Enhanced the Page model by implementing start and end time.
* TYPO3: (Domain) Created initial models for workspace and content.
* TYPO3: (Service) Implemented the Time Service which is used everywhere in the TYPO3 Domain where the current time is needed.
7 lines of code changed in 1 file:
Making FLOW3 run green(er) in FLOW3CGL, part 2. Down to 40 errors and 0 warnings from hundreds each...
864 lines of code changed in 11 files: