FLOW3 Developers: sebastian

Login name:
sebastian
Total Commits:
145 (0.8%)
Lines of Code:
4,585 (0.8%)
Most Recent Commit:
2010-06-29 12:02
Tweet this:
Tweet this

Activity by Clock Time

Activity by Hour of Day for sebastian

Activity by Day of Week for sebastian

Activity in Directories

Directory Changes Lines of Code Lines per Change
Totals 145 (100.0%) 4585 (100.0%) 31.6
Classes/MVC/Controller/ 30 (20.7%) 405 (8.8%) 13.5
Tests/Unit/Security/Channel/ 1 (0.7%) 402 (8.8%) 402.0
Tests/MVC/Controller/ 15 (10.3%) 337 (7.4%) 22.4
Classes/Property/Converter/ 4 (2.8%) 321 (7.0%) 80.2
Classes/Reflection/ 8 (5.5%) 270 (5.9%) 33.7
Tests/Property/Converter/ 3 (2.1%) 214 (4.7%) 71.3
Tests/Reflection/ 4 (2.8%) 213 (4.6%) 53.2
Classes/Property/ 9 (6.2%) 202 (4.4%) 22.4
Classes/MVC/View/ 5 (3.4%) 199 (4.3%) 39.8
Classes/Security/Channel/ 1 (0.7%) 179 (3.9%) 179.0
Classes/Property/Editor/ 4 (2.8%) 170 (3.7%) 42.5
Tests/Property/ 5 (3.4%) 147 (3.2%) 29.4
Tests/Validation/ 2 (1.4%) 132 (2.9%) 66.0
Classes/Security/Exception/ 3 (2.1%) 102 (2.2%) 34.0
Tests/Unit/Security/Cryptography/ 1 (0.7%) 96 (2.1%) 96.0
Tests/Unit/MVC/View/ 2 (1.4%) 95 (2.1%) 47.5
Tests/Property/Editor/ 2 (1.4%) 90 (2.0%) 45.0
Classes/Validation/ 2 (1.4%) 88 (1.9%) 44.0
Tests/Unit/MVC/Controller/ 4 (2.8%) 83 (1.8%) 20.7
Tests/Reflection/Fixture/ 3 (2.1%) 78 (1.7%) 26.0
Tests/Validation/Validator/ 1 (0.7%) 71 (1.5%) 71.0
Tests/Unit/Reflection/ 4 (2.8%) 69 (1.5%) 17.2
Classes/Security/Cryptography/ 2 (1.4%) 66 (1.4%) 33.0
Classes/Persistence/ 3 (2.1%) 58 (1.3%) 19.3
Tests/Property/Editor/Fixture/ 1 (0.7%) 50 (1.1%) 50.0
Tests/Property/Converter/Fixture/ 2 (1.4%) 50 (1.1%) 25.0
Classes/Validation/Validator/ 1 (0.7%) 49 (1.1%) 49.0
Tests/Unit/Object/Fixture/ 1 (0.7%) 43 (0.9%) 43.0
Tests/Persistence/ 1 (0.7%) 38 (0.8%) 38.0
Classes/MVC/Web/Routing/ 1 (0.7%) 37 (0.8%) 37.0
Classes/Validation/Exception/ 1 (0.7%) 35 (0.8%) 35.0
Classes/MVC/Exception/ 1 (0.7%) 35 (0.8%) 35.0
Documentation/Manual/DocBook/en/ 1 (0.7%) 32 (0.7%) 32.0
Classes/Security/Aspect/ 3 (2.1%) 26 (0.6%) 8.6
Classes/MVC/Web/ 1 (0.7%) 26 (0.6%) 26.0
Classes/Object/Container/ 3 (2.1%) 19 (0.4%) 6.3
Tests/Unit/Object/Container/ 2 (1.4%) 17 (0.4%) 8.5
Tests/Unit/MVC/Web/ 2 (1.4%) 17 (0.4%) 8.5
Tests/Unit/Security/Aspect/ 2 (1.4%) 8 (0.2%) 4.0
Classes/ 1 (0.7%) 7 (0.2%) 7.0
Tests/Fixtures/ 1 (0.7%) 5 (0.1%) 5.0
Tests/Unit/MVC/Web/Routing/ 2 (1.4%) 4 (0.1%) 2.0

Activity of sebastian

Most Recent Commits

sebastian 2010-06-29 12:02 Rev.: 4664

[+BUGFIX] FLOW3: Re-added AbstractView, as we need it in JsonView

72 lines of code changed in 1 file:

  • Classes/MVC/View: AbstractView.php (new 72)
sebastian 2010-06-28 19:54 Rev.: 4654

[+BUGFIX] FLOW3: Followup patch to r4653.

223 lines of code changed in 7 files:

  • Classes/MVC/View: EmptyView.php (+35 -1), JsonView.php (+37 -1), NotFoundView.php (+53 -1), ViewInterface.php (+2)
  • Classes/Property: PropertyMapper.php (+1 -1)
  • Tests/Unit/MVC/View: AbstractViewTest.php (+94), NotFoundViewTest.php (+1 -20)
sebastian 2010-06-16 11:25 Rev.: 4517

[!!!][+FEATURE] FLOW3 (Object): The lifecycle initialization method (typically initializeObject()) is now also called after recreating an object (f.e. when it is recreated from persistent storage). Additionally, initializeObject() now gets a parameter to determine if creation or recreation took place. Resolves #8258.

111 lines of code changed in 7 files:

  • Classes/Object/Container: DynamicObjectContainer.php (+1 -1), ObjectContainerBuilder.php (+6 -3), ObjectContainerInterface.php (+12)
  • Documentation/Manual/DocBook/en: ObjectFramework.xml (+32 -9)
  • Tests/Unit/Object/Container: DynamicObjectContainerTest.php (+10 -2), ObjectContainerBuilderTest.php (+7 -1)
  • Tests/Unit/Object/Fixture: ClassWithInitializeObjectMethod.php (new 43)
sebastian 2010-05-03 07:29 Rev.: 4261

[+BUGFIX] FLOW3 (Reflection): Introduced a new parameter for ObjectAccess::getPropertyPath so the caller of the method can decide if closures should be evaluated or not. Related to #7588 and r4256.

22 lines of code changed in 2 files:

  • Classes/Reflection: ObjectAccess.php (+4 -2)
  • Tests/Unit/Reflection: ObjectAccessTest.php (+18 -4)
sebastian 2010-05-02 15:21 Rev.: 4256

[!!!][+FEATURE] FLOW3 (Reflection): If an object on the path given to ObjectAccess::getPropertyPath() is a Closure, it is executed and the result is processed further. This means it is currently NOT possible to the closure itself, as it is directly executed. Resolves #7588.
[+BUGFIX] FLOW3 (Reflection): ObjectAccess::getPropertyPath now also works with classes implementing ArrayAccess.

48 lines of code changed in 2 files:

  • Classes/Reflection: ObjectAccess.php (+8 -1)
  • Tests/Unit/Reflection: ObjectAccessTest.php (+40)
sebastian 2009-10-21 10:42 Rev.: 3332

[+TASK] FLOW3 (Reflection): ObjectAccess->getProperty now supports not only ArrayObjects, but also simple arrays.

17 lines of code changed in 3 files:

  • Classes/Reflection: ObjectAccess.php (+6 -3)
  • Tests/Unit/Reflection: ObjectAccessTest.php (new)
sebastian 2009-10-13 08:17 Rev.: 3316

[+BUGFIX] FLOW3 (Security): Fixed two issues with Request Hashing. Changed hash implementation from normal SHA1 to a real HMAC. Thanks to Markus Krause for pointing this out. Relates to #4960.

7 lines of code changed in 3 files:

  • Classes/MVC/Controller: ActionController.php (+3 -1)
  • Classes/Security/Aspect: RequestDispatchingAspect.php (+1 -1)
  • Classes/Security/Cryptography: HashService.php (+3 -2)
sebastian 2009-10-09 14:20 Rev.: 3312

[BUGFIX] FLOW3 (MVC): Bugfix to automatic request hashing in context with CLI. Relates to #4960.

1 lines of code changed in 1 file:

  • Classes/MVC/Controller: ActionController.php (+1)
sebastian 2009-10-09 14:18 Rev.: 3311

[BUGFIX] FLOW3 (Security): Bugfix to automatic request hashing in context with CLI. Relates to #4960.

3 lines of code changed in 1 file:

  • Classes/Security/Aspect: RequestDispatchingAspect.php (+3 -1)
sebastian 2009-10-09 13:59 Rev.: 3309

[!!!][+FEATURE] FLOW3 (Security): Added a HMAC generator and checker to prevent unauthorized access on objects where no edit fields were generated for. It is mandatory in case objects are modified on the server side. See the issue for a more in-depth explanation. This feature does NOT break backwards-compatibility as long as you use only Fluid for form-generation. In case of custom fields, it WILL break backwards compatibility, and you might need the @dontverifyrequesthash annotation. Resolves #4960.
[+FEATURE] Fluid (ViewHelpers): Added a request hash to all form fields. It is mandatory in case objects are modified on the server side. Relates to #4960.

1135 lines of code changed in 23 files:

  • Classes/MVC/Controller: ActionController.php (+30 -2), Argument.php (+31 -1)
  • Classes/MVC/Exception: InvalidOrNoRequestHash.php (new 35)
  • Classes/MVC/Web: Request.php (+26)
  • Classes/MVC/Web/Routing: UriBuilder.php (+37 -1)
  • Classes/Security/Aspect: RequestDispatchingAspect.php (+22 -1)
  • Classes/Security/Channel: RequestHashService.php (new 179)
  • Classes/Security/Cryptography: HashService.php (new 63)
  • Classes/Security/Exception: InvalidArgumentForHashGeneration.php (new 34), InvalidArgumentForRequestHashGeneration.php (new 34), SyntacticallyWrongRequestHash.php (new 34)
  • Tests/Unit/MVC/Controller: ActionControllerTest.php (new), ArgumentTest.php (new)
  • Tests/Unit/MVC/Web: RequestTest.php (new)
  • Tests/Unit/MVC/Web/Routing: UriBuilderTest.php (new)
  • Tests/Unit/Security/Aspect: RequestDispatchingAspectTest.php (+8 -4)
  • Tests/Unit/Security/Channel: RequestHashServiceTest.php (new 402)
  • Tests/Unit/Security/Cryptography: HashServiceTest.php (new 96)
sebastian 2009-10-07 17:07 Rev.: 3298

[+FEATURE] FLOW3 (Persistence): Calls to Repository::update() will now also update the child objects if needed. This is needed if an object with sub-objects is submitted via a form. Relates to #4218.

85 lines of code changed in 2 files:

  • Classes/Persistence: Repository.php (+47 -4)
  • Tests/Persistence: RepositoryTest.php (+38 -3)
sebastian 2009-10-07 08:41 Rev.: 3296

[+TASK] FLOW3 (Reflection): Added a new helper method in ObjectAccess which can traverse object graphs (with the "."-Syntax)
[+TASK] Fluid (ViewHelpers): Refactored the generation of the hidden identity field.
[+FEATURE] Fluid (ViewHelpers): properties of nested objects are now correctly outputted, and the identity fields for the nested objects are generated as well. Related to #4218.

44 lines of code changed in 3 files:

  • Classes/Reflection: ObjectAccess.php (+19)
  • Tests/Reflection: ObjectAccessTest.php (+17 -1)
  • Tests/Reflection/Fixture: DummyClassWithGettersAndSetters.php (+8)
sebastian 2009-09-17 10:57 Rev.: 3192

[-API] FLOW3 (MVC): Removed enableValidation() and disableValidation() on the Controller Argument. They are not needed anymore.
[!!!][+BUGFIX] FLOW3 (MVC): Now, in case people do not specify an @param annotation, they will get an exception instead of Text being used.
[+BUGFIX] FLOW3 (MVC): Cleaned up validator registration in ActionController. Now, @dontvalidate annotations only disable the model-based validators.
[+BUGFIX] FLOW3 (Validation): Cleaned up ValidatorResolver. Now, Validators which check the data type from the @param annotation are also added to the validator chain.
[!!!][+BUGFIX] FLOW3 (Validation): @param string is now validated as string, and not anymore as Text. This fixes numerous bug reports in Fluid.

464 lines of code changed in 11 files:

  • Classes/MVC/Controller: ActionController.php (+29 -32), Argument.php (-43), ArgumentsValidator.php (-3)
  • Classes/Validation: ValidatorResolver.php (+34 -14)
  • Classes/Validation/Exception: InvalidValidationConfiguration.php (new 35)
  • Classes/Validation/Validator: StringValidator.php (new 49)
  • Tests/MVC/Controller: ActionControllerTest.php (+115 -71), ArgumentTest.php (-16), ArgumentsValidatorTest.php (-23)
  • Tests/Validation: ValidatorResolverTest.php (+131 -107)
  • Tests/Validation/Validator: StringValidatorTest.php (new 71)
sebastian 2009-09-15 16:15 Rev.: 3175

[!!!][~FEATURE] FLOW3 (MVC): Improved the way flash messages are handled. Now there is a separate "FlashMessages" object which encapsulates handling the flash messages. This removes $this->pushFlashMessage and $this->popFlashMessages inside the Controller and {flashMessages} inside Fluid Template. PLEASE UPGRADE by replacing "$this->pushFlashMessage(" with "$this->flashMessages->add(" inside your Controllers, and use <f:renderFlashMessages /> instead of the custom for loop inside your templates. Note: You can set a custom CSS class for outputting flash messages by using <f:renderFlashMessages class="..." /> inside your templates. Resolves #4638.

218 lines of code changed in 6 files:

  • Classes/MVC/Controller: AbstractController.php (+11 -50), ActionController.php (+1 -1), ControllerContext.php (+26), FlashMessages.php (new 88)
  • Tests/MVC/Controller: AbstractControllerTest.php (+3 -46), FlashMessagesTest.php (new 89)
sebastian 2009-09-15 12:34 Rev.: 3174

[+FEATURE] FLOW3 (MVC): Now, non-domain-objects can be mapped inside an argument as well. Additionally, improved the exceptions in these cases. Resolves #4631

70 lines of code changed in 2 files:

  • Classes/MVC/Controller: Argument.php (+37 -12)
  • Tests/MVC/Controller: ArgumentTest.php (+33 -1)
sebastian 2009-05-28 16:14 Rev.: 2448

FLOW3:
* (MVC) ActionController: Removed the injection of the ValidatorResolver, because it is already injected in the AbstractController

0 lines of code changed in 1 file:

  • Classes/MVC/Controller: ActionController.php (-18)
sebastian 2009-05-28 15:57 Rev.: 2447

FLOW3:
* (MVC) reverted my change in ActionController because I was wrong. Sorry!

0 lines of code changed in 1 file:

  • Classes/MVC/Controller: ActionController.php (-5)
sebastian 2009-05-28 15:49 Rev.: 2446

FLOW3:
* (MVC) Added $URIBuilder protected variable to ActionController. The declaration was previously missing.

5 lines of code changed in 1 file:

  • Classes/MVC/Controller: ActionController.php (+5)
sebastian 2009-03-28 17:08 Rev.: 2107

FLOW3:
* Fixed redirects in AbstractController

1 lines of code changed in 1 file:

  • Classes/MVC/Controller: AbstractController.php (+1)
sebastian 2009-03-28 15:43 Rev.: 2105

FLOW3:
* Added default arguments implementation in MVC

84 lines of code changed in 6 files:

  • Classes/MVC/Controller: ActionController.php (+2 -1), Argument.php (+24 -2), Arguments.php (+3 -1)
  • Tests/MVC/Controller: ActionControllerTest.php (+31 -2), ArgumentTest.php (+12), ArgumentsTest.php (+12)

(14 more)

Generated by StatSVN 0.5.0